refactor(utils): simplify error utility module #568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #551
Applied changes based on Issue #551.
I’ve refactored src/utils/error.ts to centralize the
instanceof Error
check into a reusable type‐guard, and updated the two existing helpers to leverage it—improving readability and avoiding duplication, with zero change in behavior. Here’s what was done:Changes in src/utils/error.ts
【F:src/utils/error.ts†L6-L13】【F:src/utils/error.ts†L20-L22】【F:src/utils/error.ts†L29-L31】
Summary of refactoring:
isError()
type‐guard for checkinginstanceof Error
.instanceof
logic intoErrorMessage
andtoErrorStack
into a single call toisError
.No other files were touched. Let me know if you’d like any additional adjustments!