fix(main): enforce timeout flag on runAction #437
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #430
Applied changes based on Issue #430.
I’ve updated
run()
insrc/main.ts
so that your configuredtimeout
‑in‑seconds now actually bounds the overallrunAction(...)
execution, not just the Codex CLI invocation. In particular:await runAction(...)
with aPromise.race
that racesrunAction
against asetTimeout
-driven rejection afterconfig.timeoutSeconds
.finally
block so there’s no leftover timer if the action completes (or fails) first.Diff of
src/main.ts
(click to expand)This ensures that if the overall action logic (including cloning, prompting, Codex runs, patching, etc.) exceeds your
timeout
input, it will abort and fail cleanly rather than run indefinitely. Let me know if you’d like any tweaks to the timeout‑error handling (e.g. posting a comment on the PR/issue).