refactor(github): extract GitHub comment update/create helper #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #383
Applied changes based on Issue #383.
I’ve centralized all of the “create‑or‑update” comment logic into a new upsertComment helper in src/github/github.ts, and updated src/github/action.ts to use it instead of the two almost‑identical inline functions (
updateFinalComment
andupdateOrCreateComment
).Changes in src/github/github.ts
Added a new helper that wraps
postComment
,issues.updateComment
, andpulls.updateReviewComment
behind a singleupsertComment
API:【F:src/github/github.ts†L914-L954】
Changes in src/github/action.ts
upsertComment
and remove the now‑unusedpostComment
import.updateFinalComment
andupdateOrCreateComment
functions.upsertComment(...)
.【F:src/github/action.ts†L9-L20】【F:src/github/action.ts†L630-L642】【F:src/github/action.ts†L234-L260】【F:src/github/action.ts†L377-L387】
Summary of refactoring
updateFinalComment
&updateOrCreateComment
).upsertComment
.action.ts
is leaner, focusing on orchestration rather than GitHub API branching.These changes keep behavior identical while centralizing comment upsert logic for progress and final‐output comments. Let me know if you’d like any tweaks!