refactor(config): rename parseEnvInput and parseListInput helpers #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
YiweiShen
approved these changes
Jul 9, 2025
YiweiShen
deleted the
codez-chore-378-refactor-config-rename-parseenvinput-and-parselistinput-helpers-3051213568
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #378
Applied changes based on Issue #378.
I’ve renamed the two helpers for clarity and updated all their usages and tests:
src/config/config.ts
parseEnvInput→parseKeyValueMapparseListInput→parseStringListgetConfig()to match the new names, and swapped theparseEnvInput(parseListInput(…))call toparseKeyValueMap(parseStringList(…)).【F:src/config/config.ts†L66-L74】【F:src/config/config.ts†L106-L113】【F:src/config/config.ts†L155-L162】
tests/unit/config/config.test.ts
parseKeyValueMapandparseStringListinstead of the old names.【F:tests/unit/config/config.test.ts†L1-L8】【F:tests/unit/config/config.test.ts†L10-L38】【F:tests/unit/config/config.test.ts†L40-L76】
These minimal changes preserve existing behavior (and existing tests) while giving the helpers names that more accurately describe their functionality. Let me know if you’d like any tweaks!