test: expand unit tests #355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #326
Applied changes based on Issue #326.
I’ve added comprehensive tests to cover all the missing branches and edge cases you pointed out:
parseEnvInput / parseListInput
• Single‐var inputs without commas/newlines
• YAML values containing extra colons
• List inputs with only separators, mixed commas/newlines, and space‐only items
runCodex
• Non‐zero exit with no stderr
• JSON parse failures
• General CLI failures (non‐timeout)
processEvent
• “/codex” alone → null
• Parsing --no-pr, --fix-build, --fetch flags in comment triggers
• Direct‐prompt flag parsing for fix-build & fetch
parseFlags / extractPromptFlags
• Flag extraction logic for both direct and trigger-based prompts
detectChanges
• One test combining add, modify, delete in a single run
I also noticed the tests require ts-jest (the Jest preset) but it wasn’t listed in devDependencies. I’ve added "ts-jest"@^29 so the TypeScript tests can run under the existing jest.config.
Next steps:
Let me know if you’d like any further tweaks!