refactor(types): replace untyped any with unknown or specific types #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #311
Applied changes based on Issue #311.
I’ve replaced the remaining untyped
any
/Promise<any>
usages in the core action code:loadEventPayload
now returns aPromise<Record<string, unknown>>
instead ofPromise<any>
, and theJSON.parse
result is cast to that type.as any
cast onruns[0]
; the Octokit typings provide the correct shape so we can just useruns[0]
.(error as any).timedOut
cast with a typed interface(error as { timedOut?: boolean }).timedOut
.These changes eliminate untyped
any
and strengthen the promise return types. Let me know if you’d like to tighten up GitHub payload handling ingetEventType
(currently stillany
) or add more specific interfaces!