feat(action): place spinner at end of process step #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
YiweiShen
approved these changes
Jun 27, 2025
YiweiShen
deleted the
codez-chore-291-feat-action-place-spinner-at-end-of-process-step
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #291
Applied changes based on Issue #291.
I’ve moved the spinner icon out of the progress‐bar line and now append it to the “in‐flight” step instead:
In createProgressComment:
• Stripped the spinner from the initial bar line.
• On listing steps, append the spinner HTML to the very first (“current”) step.
In updateProgressComment:
• Removed the spinner from the bar/percent line.
• When rendering steps, detect the first unchecked step (
completed < total) and append the spinner HTML to that line.Let me know if you’d like to tweak the spinner’s styling or placement further!