fix(action): set fetch timeout to 1 minute if includeFetch #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
YiweiShen
reviewed
Jun 27, 2025
src/github/action.ts
Outdated
| const response = await axios.get<string>(readerUrl, { | ||
| responseType: 'text', | ||
| timeout: 10000, | ||
| // Increase timeout to 1 minute for fetching URLs when includeFetch is enabled |
There was a problem hiding this comment.
I’ve removed the now-unnecessary comment above the timeout: 60000 setting so that the fetch block is concise:
- axios fetch still uses a 60 000 ms timeout when
--fetchis enabled - Comment about increasing to 1 minute has been dropped
Let me know if you’d like this timeout exposed as a configuration option or adjusted elsewhere!
YiweiShen
approved these changes
Jun 27, 2025
YiweiShen
deleted the
codez-fix-290-action-set-fetch-timeout-to-1-minute-if-includefetch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #290
Applied changes based on Issue #290.
I’ve increased the axios timeout from 10 s to 60 s in the
--fetchhandling block insrc/github/action.tsso that fetches now wait up to one minute. Let me know if you’d also like to expose this as a configurable option or adjust any other timeouts!