refactor(github): replace duplicated thumb-up reaction code #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #272
Applied changes based on Issue #272.
I’ve centralized the “eyes → thumbs-up” swap to use the existing
removeEyeReaction
andaddThumbUpReaction
helpers, and updated those helpers to also handleissuesAssigned
events.Summary of changes:
createPullRequest
, replaced the in-lined remove/insert reaction block with calls toremoveEyeReaction(octokit, repo, event)
andaddThumbUpReaction(octokit, repo, event)
.removeEyeReaction
andaddThumbUpReaction
so that they treatevent.action === 'assigned'
the same asopened
(previously they only handledopened
for issues).try/catch
increatePullRequest
to log any unexpected errors.Let me know if you’d like to tweak the logging messages or behavior further!