Add Traits and allow store of all sent expo notifications #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow store of all sent expo notifications
Problem
I was trying to store of all sent expo notifications in my database but could not find an easy way .
And since i've just implemented this package in my project and I though I'll help with some issue in the way :)
Solution
Use expo_notifications table to store all notifications by adding a
sentattributes.Add a command to clean sent notifications if user don't want to keep sent notifications.
Add Traits
Problem
Implementing the required relation for the notifiable class is not clearly documented
Solution
Add two Traits to simplify it's implementation and document it in the Readme
close #36