Closing external acces to DB#11
Merged
Yenthe666 merged 1 commit intoYenthe666:9.0from Oct 12, 2015
sebastian-code:patch-3
Merged
Closing external acces to DB#11Yenthe666 merged 1 commit intoYenthe666:9.0from sebastian-code:patch-3
Yenthe666 merged 1 commit intoYenthe666:9.0from
sebastian-code:patch-3
Conversation
With those lines you were able to access the database engine externally, something you want not in a production environment.
Owner
|
@sebastian-code this could be a problem indeed. Never noticed this myself! |
Owner
|
@sebastian-code good catch and absolutely true. I see no problems in taking this out. Thanks! 👍 |
Yenthe666
added a commit
that referenced
this pull request
Oct 12, 2015
Closing external acces to DB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With those lines you were able to access the database engine externally, something you want not in a production environment.