Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression for Swagger 1.2 schemas in release 2.0.1 #43

Closed
analogue opened this issue Nov 18, 2015 · 1 comment
Closed

Regression for Swagger 1.2 schemas in release 2.0.1 #43

analogue opened this issue Nov 18, 2015 · 1 comment
Assignees
@analogue

Comments

@analogue
Copy link
Contributor

Swagger 1.2 and 2.0 schemas both call the same common.validate_json(..) method . In release 2.0.1, this method was updated to support recursive $refs and no longer supports unqualified refererences to models. This change should only apply to Swagger 2.0 schemas. Passing in a 1.2 schema with unqualified $refs is broken.
@analogue analogue self-assigned this Nov 18, 2015
analogue pushed a commit to analogue/swagger_spec_validator that referenced this issue Nov 18, 2015
Fix regression with Swagger 1.2 specs - Yelp#43
06d025e
analogue added a commit that referenced this issue Nov 18, 2015
@analogue
Merge pull request #44 from analogue/fix_swagger12_regression
773d6bd 
Fix regression with Swagger 1.2 specs - #43
@analogue
Copy link
Contributor Author

Fixed in 2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@analogue analogue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@analogue