Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the déjà vu. So, I submitted PR #213 and checked that my patch works. After re-writing the patch as suggested, I did not, however, attempt to re-build the app again... and what do you know, the new patch was wrong.
The patch from #213 replaced the
%s
conversion specifier with%*s
. However, the%*s
conversion specifier defines the field width, i.e. minimum number of characters to print. The proper solution is to use%.*s
(note the dot), which defines the precision, i.e. the maximum number of printed characters.Again, sorry for not verifying the earlier patch. This one works fine (the Fedora package on s390x builds and passes the test suite).