Use "%.*s" when printing VERSION #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 7bb2fef attempted to fix the "missing NUL-terminator in VERSION" issue by replacing the "%s" conversion specifier with "%*s". However, this fix itself was wrong, as "%*s" specifies the field width, i.e. _minimum_ number of characters to print. The proper solution is to use "%.*s", which specifies the precision, i.e. the _maximum_ number of printed characters.
asottile
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
🤦 hah, and I had assumed you would just copy paste the code I gave you instead of rewriting it -- I was very careful to use %.*s in the suggestion I made 😆
|
I guess I wrote it by hand instead of copy-pasting since |
|
Thanks for the fix, will release this in 1.2.4 (will take a little bit, waiting on Travis to build it for all architectures now). |
|
Released in v1.2.4: https://github.com/Yelp/dumb-init/releases/tag/v1.2.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the déjà vu. So, I submitted PR #213 and checked that my patch works. After re-writing the patch as suggested, I did not, however, attempt to re-build the app again... and what do you know, the new patch was wrong.
The patch from #213 replaced the
%sconversion specifier with%*s. However, the%*sconversion specifier defines the field width, i.e. minimum number of characters to print. The proper solution is to use%.*s(note the dot), which defines the precision, i.e. the maximum number of printed characters.Again, sorry for not verifying the earlier patch. This one works fine (the Fedora package on s390x builds and passes the test suite).