chore: changes to be compatible with YLT v3#2
Draft
ohoareau wants to merge 3 commits intoYellowLabTools:mainfrom
Draft
chore: changes to be compatible with YLT v3#2ohoareau wants to merge 3 commits intoYellowLabTools:mainfrom
ohoareau wants to merge 3 commits intoYellowLabTools:mainfrom
Conversation
Contributor
|
Hi Olivier, The "Unhandled Promise Rejection" error you encountered is related to a Puppeteer option called The fix in Phantomas is not ready yet, so I can't update YLT, but I tested a hotfix on my local docker image. Here is a line I added to your Dockerfile.lambda file (this command adds a double slash at the beginning of the line 35): It might be used as a temporary fix. I'll let you know when the final fix is available. |
this reduces the generated report data's size sent to symphony (from ~1.1M to 300K on google.com)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.