Good GiB passing - #152
Merged
Merged
Conversation
YanivZalach
commented
Aug 23, 2026
YanivZalach
commented
Aug 23, 2026
Backend emits byte counts as strings instead of pre-converted GiB: data files carry file_size_in_bytes, and snapshot summary size keys gain a -bytes suffix with Iceberg's values passed through untouched. The frontend converts to GiB at display time. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
YanivZalach
force-pushed
the
t3code/refactor/gib-field-naming
branch
from
August 24, 2026 17:06
07bdee1 to
227dc4b
Compare
Narrow formatBytesAsGibibytes to accept only strings and update its one typed caller to pass the raw string. Convert snapshot summary byte sizes with an explicit str() so the returned type is guaranteed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
YanivZalach
commented
Aug 25, 2026
Panel rows converted byte fields to GiB but kept labels like file_size_in_bytes, so the label contradicted the value. Strip the suffix for display and reuse the same rule for the metrics table header. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
endsWith("bytes") also matched fields like total_kilobytes, which would
be converted to GiB with an unstripped label. Require the suffix to be
delimited, and share one pattern between detection and stripping.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Drop the exponential fallback so small sizes read as 0.00419 MiB rather than 4.098e-6 GiB. Panel rows and the readable metrics table now use MiB; the metadata page table size stays in GiB. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.