Skip to content

Commit

Permalink
Format-The-Codebase
Browse files Browse the repository at this point in the history
- update scripts
  • Loading branch information
omerXfaruq committed Feb 10, 2022
1 parent 934071d commit 47b4b69
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 5 deletions.
10 changes: 8 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,14 @@ All PRs should be against `master`. Direct commits to master are blocked, and PR
* A maintainer (@abidlabs, @aliabid94, @aliabd, @AK391, or @dawoodkhan82) is tagged in the PR comments and asked to complete a review

We ask that you make sure initial CI checks are passing before requesting a review. One of the Gradio maintainers will merge the PR when all the checks are passing.
Do not forget the format the codebase before pushing.

Do not forget the format the backend before pushing.
```
bash scripts/run_frontend.sh
bash scripts/format_backend.sh
```
You can run the circleci checks locally as well.
```
bash scripts/run_circleci.sh
```

*Could these guidelines be clearer? Feel free to open a PR to help us faciltiate open-source contributions!*
3 changes: 0 additions & 3 deletions scripts/build_frontend.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,3 @@ else
npm install
npm run build
fi



File renamed without changes.
11 changes: 11 additions & 0 deletions scripts/run_circleci.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#!/bin/bash
if [ -z "$(ls | grep CONTRIBUTING.md)" ]; then
echo "Please run the script from repo directory"
exit -1
else
echo "Running circleci locally"
circleci local execute
fi



0 comments on commit 47b4b69

Please sign in to comment.