Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: output completion message when scan is finished #1462

Merged

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Oct 25, 2024

What Changed

Evidence

% ./hayabusa csv-timeline -d ../hayabusa-sample-evtx -w

スクリーンショット 2024-10-25 3 07 47

% ./hayabusa csv-timeline -d ../hayabusa-sample-evtx -w -o timeline.csv

スクリーンショット 2024-10-25 3 09 10

I would appreciate it if you could check it out when you have time🙏

@fukusuket fukusuket self-assigned this Oct 25, 2024
@fukusuket fukusuket added the bug Something isn't working label Oct 25, 2024
@fukusuket fukusuket marked this pull request as ready for review October 25, 2024 07:13
@YamatoSecurity
Copy link
Collaborator

@fukusuket Thanks so much! I check that it is working well for both csv-timeline and json-timeline.

For json-timeline, the output at the end is like this:

        "Count": 14,
        "TargetUserName": "jlake/ssims/edygert/bking/mdouglas/jorchilles/bgalbraith/baker/cspizor/cragoso/smisenar/bgreenwood/dmashburn/drook",
        "IpAddress": "172.16.144.128"
    },
    "ExtraFieldInfo": {}
}
{
    "Timestamp": "2016-09-20 01:50:06.513 +09:00",
    "RuleTitle": "PW Guessing",
    "Level": "med",
    "Computer": "DESKTOP-M5SN04R",
    "Channel": "Sec",
    "EventID": 4625,
    "RecordID": "-",
    "Details": {
        "Count": 3558,
        "TargetUserName": "Administrator",
        "TargetDomainName": ".",
        "IpAddress": "192.168.198.149",
        "LogonType": 3,
        "ProcessName": "-",
        "LogonProcessName": "NtLmSsp"
    },
    "ExtraFieldInfo": {}
}
[00:00:19] 584 / 584   [========================================] 100%

Scanning finished.

Rule Authors:

Is it possible to add a space just before the progress bar?

Ex:

}

[00:00:19] 584 / 584   [========================================] 100%

@fukusuket
Copy link
Collaborator Author

@YamatoSecurity
Thank you for checking :) I fixed it!!

% ./hayabusa json-timeline -d ../hayabusa-sample-evtx/YamatoSecurity -w -q
...
        "CVEID": "[CVE-2020-0601] cert validation"
    }
}

[00:00:00] 13 / 13   [========================================] 100%

Scanning finished.

Rule Authors:

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket LGTM! Thanks so much!

@YamatoSecurity YamatoSecurity merged commit 0f4fc84 into main Oct 25, 2024
5 checks passed
@YamatoSecurity YamatoSecurity deleted the 1459-results-get-outputted-after-scanning-has-finished branch October 25, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: results get outputted after scanning has finished.
2 participants