Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sigma v2 cased modifier support #1401

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

hitenkoku
Copy link
Collaborator

What Changed

  • added sigma v2 cased modifier support

@hitenkoku hitenkoku linked an issue Aug 16, 2024 that may be closed by this pull request
Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed startwith/contains/endswith + cased works :) LGTM!!🚀
I tested with following rule.

eventcreate /t INFORMATION /id 1 /d "abc"
title: cased TEST
id: 0550d910-7787-4892-9791-c1c6a26ec16a
status: test
author: TEST
logsource:
    product: windows
    category: application
detection:
    selection:
        EventID: 1
        Channel: Application
        Data|startswith|cased: "a"
        #Data|startswith|cased: "A"
        #Data|endswith|cased: "c"
        #Data|endswith|cased: "C"
        #Data|contains|cased: "b" 
        #Data|contains|cased: "B"               
    condition: selection
level: informational

also there is no diff compared with main.
https://github.com/Yamato-Security/hayabusa/actions/runs/10415100229

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket Thanks for testing! @hitenkoku LGTM! Thanks so much!

@YamatoSecurity YamatoSecurity merged commit d105a33 into main Aug 16, 2024
5 checks passed
@YamatoSecurity YamatoSecurity deleted the 1398-sigma-v2-cased-modifier-support branch August 16, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sigma V2 cased modifier support
3 participants