added sigma v2 exists modifier support #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hitenkoku Thanks for this! sorry I merged the other PR so I think there is a conflict now. |
fukusuket
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
I confirmed it works :) LGTM!!🚀
I checked by following rule!
eventcreate /t INFORMATION /id 1 /d "abc"
hayabusa.exe csv-timeline -l --timeline-offset 10m -r test.yml -w -a -A
title: exists TEST
id: 0550d910-7787-4892-9791-c1c6a26ec16a
status: test
author: TEST
logsource:
product: windows
category: application
detection:
selection:
EventID: 1
Channel|exists: true
#Channel|exists: false
condition: selection
level: informationalalso there is no diff compared with main.
https://github.com/Yamato-Security/hayabusa/actions/runs/10416679653
YamatoSecurity
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
@fukusuket Thanks for testing! @hitenkoku LGTM! Thanks so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed