-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated cidr-utils crate to 0.6 #1366
updated cidr-utils crate to 0.6 #1366
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
==========================================
- Coverage 80.77% 80.33% -0.45%
==========================================
Files 27 28 +1
Lines 25420 25781 +361
==========================================
+ Hits 20533 20710 +177
- Misses 4887 5071 +184 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed following cidr rule works :) LGTM!!🚀
title: TEST
id: 56a1bb6f-e039-3f65-3ea0-de425cefa8a7
status: test
author: test
date: 2023/01/19
logsource:
product: windows
service: security
detection:
selection:
Channel: Security
EventID: 4624
filter:
IpAddress|cidr:
- 192.168.0.0/16
condition: selection and not filter
level: medium
% ./hayabusa json-timeline -d ../hayabusa-sample-evtx -r test2.yml -w
{
"Timestamp": "2022-05-01 13:42:00.800 +09:00",
"RuleTitle": "External Remote RDP Logon from Public IP",
"Level": "med",
"Computer": "wind10.winlab.local",
"Channel": "Sec",
"EventID": 4624,
"RecordID": 21373,
"Details": {
"Type": "3 - NETWORK",
"TgtUser": "Administrator",
"SrcComp": "-",
"SrcIP": "192.168.1.219",
"LID": "0x82215a"
},
"ExtraFieldInfo": {
"AuthenticationPackageName": "Kerberos",
"ElevatedToken": "YES",
"ImpersonationLevel": "IMPERSONATION",
"IpPort": 63652,
"KeyLength": 0,
"LogonGuid": "59CEFB69-4F9D-7486-C449-471E00B814E3",
"LogonProcessName": "Kerberos",
"ProcessId": 0,
"SubjectLogonId": "0x0",
"SubjectUserSid": "S-1-0-0",
"TargetDomainName": "WINLAB.LOCAL",
"TargetLinkedLogonId": "0x0",
"TargetUserSid": "S-1-5-21-81107902-1099128984-1836738286-500",
"VirtualAccount": "NO"
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hitenkoku LGTM! Thanks so much!
What Changed
I would appreciate it if you could check it out when you have time