Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated cidr-utils crate to 0.6 #1366

Merged

Conversation

hitenkoku
Copy link
Collaborator

What Changed

  • updated cidr-utils crate to 0.6

I would appreciate it if you could check it out when you have time

@hitenkoku hitenkoku self-assigned this Jun 15, 2024
@hitenkoku hitenkoku linked an issue Jun 15, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.33%. Comparing base (2173b4e) to head (53a6c22).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
- Coverage   80.77%   80.33%   -0.45%     
==========================================
  Files          27       28       +1     
  Lines       25420    25781     +361     
==========================================
+ Hits        20533    20710     +177     
- Misses       4887     5071     +184     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed following cidr rule works :) LGTM!!🚀

title: TEST
id: 56a1bb6f-e039-3f65-3ea0-de425cefa8a7
status: test
author: test
date: 2023/01/19
logsource:
    product: windows
    service: security
detection:
    selection:
        Channel: Security
        EventID: 4624
    filter:
        IpAddress|cidr:
           - 192.168.0.0/16
    condition: selection and not filter
level: medium

% ./hayabusa json-timeline -d ../hayabusa-sample-evtx -r test2.yml -w

{
    "Timestamp": "2022-05-01 13:42:00.800 +09:00",
    "RuleTitle": "External Remote RDP Logon from Public IP",
    "Level": "med",
    "Computer": "wind10.winlab.local",
    "Channel": "Sec",
    "EventID": 4624,
    "RecordID": 21373,
    "Details": {
        "Type": "3 - NETWORK",
        "TgtUser": "Administrator",
        "SrcComp": "-",
        "SrcIP": "192.168.1.219",
        "LID": "0x82215a"
    },
    "ExtraFieldInfo": {
        "AuthenticationPackageName": "Kerberos",
        "ElevatedToken": "YES",
        "ImpersonationLevel": "IMPERSONATION",
        "IpPort": 63652,
        "KeyLength": 0,
        "LogonGuid": "59CEFB69-4F9D-7486-C449-471E00B814E3",
        "LogonProcessName": "Kerberos",
        "ProcessId": 0,
        "SubjectLogonId": "0x0",
        "SubjectUserSid": "S-1-0-0",
        "TargetDomainName": "WINLAB.LOCAL",
        "TargetLinkedLogonId": "0x0",
        "TargetUserSid": "S-1-5-21-81107902-1099128984-1836738286-500",
        "VirtualAccount": "NO"
    }
}

Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hitenkoku LGTM! Thanks so much!

@YamatoSecurity YamatoSecurity merged commit f0e9b7b into main Jun 15, 2024
7 checks passed
@YamatoSecurity YamatoSecurity deleted the 1222-cidr-utils-61-crate-causes-compilation-error branch June 15, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cidr-utils 6.1 crate causes compilation error
3 participants