-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove replace subtoken #1268
Remove replace subtoken #1268
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
+ Coverage 82.18% 82.23% +0.05%
==========================================
Files 27 27
Lines 24313 24241 -72
==========================================
- Hits 19981 19935 -46
+ Misses 4332 4306 -26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that there is no difference with 2.12.0 using the csv-timeline/json-timeline command :) LGTM!!🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your pull request.
LGTM
#787
What Changed
change parse condition logic in order to remove unnecessary function and in order not to create unnecessary token instance.
Evidence
The testcases have passed.