Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove replace subtoken #1268

Merged
merged 5 commits into from
Feb 3, 2024
Merged

Remove replace subtoken #1268

merged 5 commits into from
Feb 3, 2024

Conversation

hach1yon
Copy link
Collaborator

@hach1yon hach1yon commented Feb 3, 2024

#787

What Changed

change parse condition logic in order to remove unnecessary function and in order not to create unnecessary token instance.

Evidence

The testcases have passed.

@hach1yon hach1yon marked this pull request as draft February 3, 2024 15:32
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (19c8c06) 82.18% compared to head (ff96069) 82.23%.

Files Patch % Lines
src/detections/rule/condition_parser.rs 86.86% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
+ Coverage   82.18%   82.23%   +0.05%     
==========================================
  Files          27       27              
  Lines       24313    24241      -72     
==========================================
- Hits        19981    19935      -46     
+ Misses       4332     4306      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hach1yon hach1yon marked this pull request as ready for review February 3, 2024 15:51
@hitenkoku hitenkoku added the enhancement New feature or request label Feb 3, 2024
Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that there is no difference with 2.12.0 using the csv-timeline/json-timeline command :) LGTM!!🚀

Copy link
Collaborator

@hitenkoku hitenkoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your pull request.
LGTM

@hitenkoku hitenkoku merged commit 290d317 into main Feb 3, 2024
7 checks passed
@hach1yon hach1yon deleted the remove_replace_subtoken branch February 4, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants