-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed search
command line options associate
#1261
fixed search
command line options associate
#1261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed the success of the Integration-Test below :) LGTM!!🚀
https://github.com/Yamato-Security/hayabusa/actions/runs/7748410799
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hitenkoku Thanks so much! LGTM! I just added a clarification to the help menu to say the option is for CSV output.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
=======================================
Coverage 82.20% 82.20%
=======================================
Files 27 27
Lines 24305 24305
=======================================
Hits 19981 19981
Misses 4324 4324 ☔ View full report in Codecov by Sentry. |
@YamatoSecurity @fukusuket Thanks for review. I will merge it. |
What Changed
Evidence
Please check previous version result in Make
search
command line options stricter #1257 description.this PR
I would appreciate it if you could review when you have time.