Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1067 word wrap in cell when event title is long #1094

Merged

Conversation

garigariganzy
Copy link
Collaborator

What Changed

  • Changed 1
    Fixed the metrics content only to dynamically wrap to maintain the specified table width (100 characters).

Evidence

1067_metrics_image

Please describe the functionality gained by merging this pull-request and the evidence that the bug has been fixed.

@YamatoSecurity YamatoSecurity added the enhancement New feature or request label Jun 12, 2023
@YamatoSecurity YamatoSecurity added this to the v2.6.0 milestone Jun 12, 2023
@YamatoSecurity
Copy link
Collaborator

@garigariganzy ありがとうございます!
見出しのCountTotalにして、Percent%に変えて頂けますか?
(英語的にTotalの方が自然で、Percentにすると(少しだけだけど)列の幅が必要以上に広くなるので、少しでも狭くしたいです。
また、Channelの最大数字を20文字にできますか?

そうすると、Count ~ IDの文は50文字で収まるはずです。Windows 10のデフォルトのCommand Promptの120文字のターミナルでもテーブルが壊れないようにしたいのですが、Eventの幅をターミナルの幅 - 55という風に設定できますか?
(※50はCount ~ IDの文で、テーブルの右側の線: のためにプラス5文字を入れています)
terminal widthの調べ方等が分からなかったら、 @hitenkoku に聞いて下さい。

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 95.45% and project coverage change: +0.01 🎉

Comparison is base (ecb2027) 82.03% compared to head (7b8d7a5) 82.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
+ Coverage   82.03%   82.05%   +0.01%     
==========================================
  Files          24       24              
  Lines       20010    20029      +19     
==========================================
+ Hits        16416    16434      +18     
- Misses       3594     3595       +1     
Impacted Files Coverage Δ
src/timeline/timelines.rs 88.17% <95.45%> (+0.17%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hitenkoku hitenkoku marked this pull request as ready for review June 15, 2023 06:51
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garigariganzy LGTM! Thank you!
@hitenkoku If this is good with you, let's merge it.

Copy link
Collaborator

@hitenkoku hitenkoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hitenkoku hitenkoku merged commit c9e4732 into main Jun 15, 2023
@hitenkoku hitenkoku deleted the feature/1067-word-wrap-in-cell-when-event-title-is-long branch June 15, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants