You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current update-rules command is designed to only update files where the modified field has been updated, so changes like the commit below will not be reflected in the rules. https://github.com/SigmaHQ/sigma/pull/4651/files
fukusuket
changed the title
update-rules does not update rule files when status is updatedupdate-rules does not update rules file if only status field is updated
Jan 3, 2024
Thanks for pointing this out. Maybe we should update the files if there are any differences in the text (like the diff command) instead of checking fields? @hitenkoku What do you think?
fukusuket
changed the title
update-rules does not update rules file if only status field is updatedupdate-rules does not update rule files if only status field is updated
Jan 4, 2024
I have checked and it is done in the same way as when you do a git pull in the rules folder.
Currently, the display of the number of units changed, etc. is certainly not seeing the status changes, so I will fix it.
Describe the issue
This is not a bug, but
update-rules
does not update rule files whenstatus
is updated.According to the Sigma spec below, the
modified
field is not updated when thestatus
changes(exceptdeprecated
).https://github.com/SigmaHQ/sigma-specification/blob/main/Sigma_specification.md#modified-optional
The current
update-rules
command is designed to only update files where themodified
field has been updated, so changes like the commit below will not be reflected in the rules.https://github.com/SigmaHQ/sigma/pull/4651/files
As a result, the rules classified by the
scan-wizard
below do not match the latest classifications in the Sigma repositoryhttps://github.com/Yamato-Security/hayabusa?tab=readme-ov-file#scan-wizard
Step to Reproduce
(As of 2024/1/3)
Actual behavior
(As of 2024/1/3)
Updated Sigma rules: 2
Expected behavior
The
status
field will be updated as in the commit below.https://github.com/SigmaHQ/sigma/pull/4651/files
Personally, I think the above specifications are better, but what do you think?🤔
Environment
The text was updated successfully, but these errors were encountered: