Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement color applying for scale and angle texts, fixing color appl… #611

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

Marina24
Copy link

#602 Implement color applying for scale and angle texts, fixing color applying for middle progress wheel line, remove unused method setActiveWidgetColor() which dublicate setActiveControlsWidgetColor()

…ying for middle progress wheel line, remove unused method setActiveWidgetColor() which dublicate setActiveControlsWidgetColor()
# Conflicts:
#	ucrop/src/main/java/com/yalantis/ucrop/UCropActivity.java
#	ucrop/src/main/java/com/yalantis/ucrop/UCropFragment.java
@p1nkydev p1nkydev merged commit 909874e into develop Mar 18, 2020
@p1nkydev p1nkydev deleted the fix/active_color_widget_issue_602 branch March 18, 2020 14:55
@friederikewild
Copy link

friederikewild commented May 7, 2020

Just noticed that due to this in version 2.2.5 we lose setActiveWidgetColor. I actually was using two different colours to have white as action icons, but our primary app colour for the controls e.g. the "scale" marker. To me, it was not at all a duplicate of setActiveControlsWidgetColor as our active colour is a bit too dark on the grey bottom area to use the same for both.

Could we please bring back the different colour option @Marina24 @p1nkydev? Should I create a new issue? Also, the documentation of setActiveControlsWidgetColor now is wrong as the default seems to be "orange" now instead of "white"?

Update: I've revisited the whole styling and changed the ucrop_color_widget_background to be white - actually looks even nicer than before.
Might be worth adding this breaking change to the release notes of 2.2.5 for others to be aware of it @ukevgen :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants