Skip to content

add FR translation file #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cool04ek merged 2 commits into from
Nov 14, 2016
Merged

add FR translation file #229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
834a344
add FR translation file (#1)
clemp6r Nov 14, 2016
014d3ae
fix typo in FR translations
clemp6r Nov 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ucrop/src/main/res/values-fr/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<resources>
Copy link
Copy Markdown
Contributor

@Cool04ek Cool04ek Nov 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It lack translation for two more strings - ucrop_error_input_data_is_absent and ucrop_mutate_exception_hint

Copy link
Copy Markdown
Contributor Author

@clemp6r clemp6r Nov 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are exception messages. It's not common to translate this kind of messages, because they're used for logging, not for showing to the user. Everything in the logcat is in english: having translated messages in the logs might be confusing. Also you can see that they're not translated in NL and SK.

I think these strings should not be externalized at all. They should be directly found in the source code.

<string name="ucrop_label_original">Original</string>
<string name="ucrop_label_edit_photo">Modifier la photo</string>
<string name="ucrop_menu_crop">Recadrer</string>
</resources>