bug YouTube (KeepLandscapeModePatch): PIP issue when lock/unlock screen

[MarcaDian]

Type

Error at runtime

Tools used

RVX Manager

Application

v19.04.47

Bug description

Go to ReVanced Extended - Fullscreen - enable Keep landscape mode
Open video, expand to full screen, lock screen, unlock screen, minimize to landscape mode, go to desktop

Result:
PIP displays content below the video player

Error logs

No response

Solution

No response

Additional context

No response

Device Environment

A12 MIUI 13

Acknowledgements

• This issue does not reproduce on unpatched YouTube or YT Music.
• This issue is not a duplicate of an existing bug report.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• I have written the title and contents in English.

[YT-Advanced]

Any video pls, I still cannot know how to produce this issues

[MarcaDian]

Screenrecorder-2024-02-14-09-40-04-711.1.mp4

[YT-Advanced]

Thanks, I will try to fix it

[MondayNitro]

Thanks, I will try to fix it

bro its not yt issue, it is rom issue bcs yt uses androids built-in pip player, it doesnt have it own pip mode (like newpipe)

[YT-Advanced]

hi, today I checked and cannot reproduce this issues in my side, can you share your settings

[MarcaDian]

hi, today I checked and cannot reproduce this issues in my side, can you share your settings

Standard settings after installing the application, only enabled ReVanced Extended - Fullscreen - enable Keep landscape mode and landscape timeout 180000

"always_repeat": true,
"enable_save_playback_speed": true,
"hide_shopping_links": false,
"keep_landscape_mode": true,
"keep_landscape_mode_timeout": 180000,
"overlay_button_always_repeat": true,
"swipe_brightness_auto": false,
"swipe_brightness_value": 1

[MarcaDian]

another user also has this bug - https://4pda.to/forum/index.php?act=findpost&pid=128330371&anchor=Spoil-128330371-1

[YT-Advanced]

Hmm, I still can't reproduce this issues. I think I will remove this feature in next release

[WhisperRevanced]

Hmm, I still can't reproduce this issues. I think I will remove this feature in next release

You need to turn on "keep landscape mode", then open in full-screen video, lock then unlock phone, press home button to switch on PiP mode.


Upd : 3000ms not enough for keep landscape mode👌, then we increased to 1 800 000(30min) it doesn’t matter how many minutes are set, people don't block their phone for 3 seconds. That's why you don't have time to see the bug, Player just leaving by landscape mode to vertical.

[MarcaDian]

Maybe this issue only on MIUI or similar firmware shell. Don't remove this feature, just add notice message into keep landscape string about this bug.

[WhisperRevanced]

Maybe this issue only on MIUI or similar firmware shell

Не, у меня же One UI Core, я дополнил пост разъяснениями

We need this functionality, it is very useful, we need to bring the matter to full working order 🤗

[YT-Advanced]

@WhisperRevanced I know, I have trying to reproduce this issues in all my devices (both virtual and physical devices) and still cannot have this issues, weird.

[WhisperRevanced]

@YT-Advanced as the friend above says, you need to save this, but add to it a description about the PiP bug on some devices 🤝
This is a very necessary functionality and was asked a lot on the 4pda forum
I won’t lie, we use it ourselves very often and are happy about this innovation 🤩
Would also really like to see such functionality on versions 18.25.40 and 18.29.38, if the opportunity arises 🙏