PA-99 Fixed app failing to launch on BlueSky #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongranger
force-pushed
the
PA-99
branch
3 times, most recently
from
eea4239 to
592020c
Compare
nickwangyoui
approved these changes
May 23, 2019
lib/basedevice.js
Outdated
| @@ -15,12 +15,12 @@ class BaseDevice { | |||
| logger.errorAndThrow(msg); | |||
| } | |||
|
|
|||
| installApp (appPath) { | |||
| installApp (appPath) { // eslint-disable-line no-unused-vars | |||
| let msg = `installApp is not supported on this platform`; | |||
| logger.errorAndThrow(msg); | |||
There was a problem hiding this comment.
Can use logger.errorAndThrow('ErrorMessage') instead of using a variable.
lib/basedevice.js
Outdated
| let msg = `installApp is not supported on this platform`; | ||
| logger.errorAndThrow(msg); | ||
| } | ||
|
|
||
| isAppInstalled (channelId) { | ||
| isAppInstalled (channelId) { // eslint-disable-line no-unused-vars | ||
| let msg = `isAppInstalled is not supported on this platform`; | ||
| logger.errorAndThrow(msg); |
| break; | ||
| case "yitvos": | ||
| case "yitvos": { | ||
| let shell = require('shelljs'); | ||
| if (shell.exec(`instruments -s devices | grep '${caps.udid}'`).includes('(Simulator)')) { |
There was a problem hiding this comment.
Can be one line, doesnt really matter.
if (shell.exec(instruments -s devices | grep '${caps.udid}').includes('(Simulator)')) this.device = . new TvOsSimulator();
There was a problem hiding this comment.
expected bracket after if statement
lib/driver.js
Outdated
| case "noproxy": | ||
| case "connecttoapp": | ||
| break; | ||
| default: | ||
| default: { | ||
| let msg = `Unsupported platformName: ${caps.platformName}`; | ||
| logger.errorAndThrow(msg); |
There was a problem hiding this comment.
same with single line
default:
logger.errorAndThrow(Unsupported platformName: ${caps.platformName});
(no braces needed because there's no var declaration.)
simongranger
force-pushed
the
PA-99
branch
2 times, most recently
from
863b8b1 to
77b5e72
Compare
Also resoved eslint warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.