Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sept updates #56

Merged
merged 19 commits into from
Sep 20, 2023
Merged

Sept updates #56

merged 19 commits into from
Sep 20, 2023

Conversation

froboy
Copy link
Collaborator

@froboy froboy commented Sep 14, 2023 •
edited
Loading

@froboy
Copy link
Collaborator Author

froboy commented Sep 15, 2023

@krknopp I've replied to all of your comments in 60a77fa. Great feedback, thank you. I hope this helps.

@froboy froboy marked this pull request as ready for review September 19, 2023 17:25
podarok
podarok approved these changes Sep 20, 2023
View reviewed changes
Copy link

@podarok podarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

@froboy @podarok
Apply suggestions from code review
f866dc4 
Co-authored-by: Andrii Podanenko <podarokua@gmail.com>
@podarok podarok merged commit 2179f99 into main Sep 20, 2023
@podarok podarok deleted the sept-updates branch September 20, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krknopp krknopp krknopp left review comments

@podarok podarok podarok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@froboy @podarok @krknopp