Add support for embedding hardgif #540
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anon-a-miss
force-pushed
the
feature/addHardgif
branch
from
14ac5ff to
2efa5ca
Compare
Author
|
@Xyphyn Could you please consider merging this and #539? I've tested both and haven't seen any issues. The only change I'd suggest is adding the original link in case the embed changes don't work or the link contains more content. As they are similar, if you merge both please check that the full changes are added. However I can rebase the second change after the first is merged. I'm thinking of adding more embeds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled embedding of hardgif. I've followed what you did with YouTube.
It may help to include the original link above or below the embed, as the page may include a link to the original content that it was created from.