Skip to content

Commit

Permalink
[Enhancement] Remove cachelib library and dependencies to reduce the …
Browse files Browse the repository at this point in the history
…thirdparty space. (StarRocks#42660)
  • Loading branch information
GavinMar authored Mar 15, 2024
1 parent 520fbe2 commit 30e7e97
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 48 deletions.
21 changes: 0 additions & 21 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -182,20 +182,6 @@ if [ -e /proc/cpuinfo ] ; then
fi
fi

# The `WITH_CACHELIB` just controls whether cachelib is compiled in, while starcache is controlled by "USE_STAROS".
# This option will soon be deprecated.
if [[ "${MACHINE_TYPE}" == "aarch64" ]]; then
# force turn off cachelib on arm platform
WITH_CACHELIB=OFF
elif [[ -z ${WITH_CACHELIB} ]]; then
WITH_CACHELIB=OFF
fi

if [[ "${WITH_CACHELIB}" == "ON" && ! -f ${STARROCKS_THIRDPARTY}/installed/cachelib/lib/libcachelib_allocator.a ]]; then
echo "WITH_CACHELIB=ON but missing depdency libraries(cachelib)"
exit 1
fi

if [[ -z ${ENABLE_QUERY_DEBUG_TRACE} ]]; then
ENABLE_QUERY_DEBUG_TRACE=OFF
fi
Expand Down Expand Up @@ -282,7 +268,6 @@ echo "Get params:
JEMALLOC_DEBUG -- $JEMALLOC_DEBUG
PARALLEL -- $PARALLEL
ENABLE_QUERY_DEBUG_TRACE -- $ENABLE_QUERY_DEBUG_TRACE
WITH_CACHELIB -- $WITH_CACHELIB
ENABLE_FAULT_INJECTION -- $ENABLE_FAULT_INJECTION
BUILD_JAVA_EXT -- $BUILD_JAVA_EXT
OUTPUT_COMPILE_TIME -- $OUTPUT_COMPILE_TIME
Expand Down Expand Up @@ -377,7 +362,6 @@ if [ ${BUILD_BE} -eq 1 ] ; then
-DWITH_BENCH=${WITH_BENCH} \
-DWITH_CLANG_TIDY=${WITH_CLANG_TIDY} \
-DWITH_COMPRESS=${WITH_COMPRESS} \
-DWITH_CACHELIB=${WITH_CACHELIB} \
-DUSE_STAROS=${USE_STAROS} \
-DENABLE_FAULT_INJECTION=${ENABLE_FAULT_INJECTION} \
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON ..
Expand Down Expand Up @@ -546,11 +530,6 @@ if [ ${BUILD_BE} -eq 1 ]; then
rm -f ${STARROCKS_OUTPUT}/be/lib/hadoop/common/lib/log4j-1.2.17.jar
rm -f ${STARROCKS_OUTPUT}/be/lib/hadoop/hdfs/lib/log4j-1.2.17.jar

if [ "${WITH_CACHELIB}" == "ON" ]; then
mkdir -p ${STARROCKS_OUTPUT}/be/lib/cachelib
cp -r -p ${CACHELIB_DIR}/deps/lib64 ${STARROCKS_OUTPUT}/be/lib/cachelib/
fi

MSG="${MSG}${MSG_BE}"
fi

Expand Down
14 changes: 0 additions & 14 deletions run-be-ut.sh
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,6 @@ if [ ! -d ${CMAKE_BUILD_DIR} ]; then
mkdir -p ${CMAKE_BUILD_DIR}
fi

# The `WITH_CACHELIB` just controls whether cachelib is compiled in, while starcache is controlled by "USE_STAROS".
# This option will soon be deprecated.
if [[ "${MACHINE_TYPE}" == "aarch64" ]]; then
# force turn off cachelib on arm platform
WITH_CACHELIB=OFF
elif [[ -z ${WITH_CACHELIB} ]]; then
WITH_CACHELIB=OFF
fi

source ${STARROCKS_HOME}/bin/common.sh

cd ${CMAKE_BUILD_DIR}
Expand All @@ -183,7 +174,6 @@ ${CMAKE_CMD} -G "${CMAKE_GENERATOR}" \
-DUSE_STAROS=${USE_STAROS} \
-DSTARLET_INSTALL_DIR=${STARLET_INSTALL_DIR} \
-DWITH_GCOV=${WITH_GCOV} \
-DWITH_CACHELIB=${WITH_CACHELIB} \
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON ../

${BUILD_SYSTEM} -j${PARALLEL}
Expand Down Expand Up @@ -230,10 +220,6 @@ else
fi

export LD_LIBRARY_PATH=$STARROCKS_HOME/lib/hadoop/native:$LD_LIBRARY_PATH
if [ "${WITH_CACHELIB}" == "ON" ]; then
CACHELIB_DIR=${STARROCKS_THIRDPARTY}/installed/cachelib
export LD_LIBRARY_PATH=$CACHELIB_DIR/lib:$CACHELIB_DIR/lib64:$CACHELIB_DIR/deps/lib:$CACHELIB_DIR/deps/lib64:$LD_LIBRARY_PATH
fi

THIRDPARTY_HADOOP_HOME=${STARROCKS_THIRDPARTY}/installed/hadoop/share/hadoop
if [[ -d ${THIRDPARTY_HADOOP_HOME} ]] ; then
Expand Down
6 changes: 0 additions & 6 deletions thirdparty/build-thirdparty.sh
Original file line number Diff line number Diff line change
Expand Up @@ -1091,11 +1091,6 @@ build_fast_float() {
cp -r $TP_SOURCE_DIR/$FAST_FLOAT_SOURCE/include $TP_INSTALL_DIR
}

build_cachelib() {
check_if_source_exist $CACHELIB_SOURCE
rm -rf $TP_INSTALL_DIR/$CACHELIB_SOURCE && mv $TP_SOURCE_DIR/$CACHELIB_SOURCE $TP_INSTALL_DIR/
}

build_starcache() {
check_if_source_exist $STARCACHE_SOURCE
rm -rf $TP_INSTALL_DIR/$STARCACHE_SOURCE && mv $TP_SOURCE_DIR/$STARCACHE_SOURCE $TP_INSTALL_DIR/
Expand Down Expand Up @@ -1322,7 +1317,6 @@ build_vpack
build_opentelemetry
build_benchmark
build_fast_float
build_cachelib
build_starcache
build_streamvbyte
build_jansson
Expand Down
8 changes: 1 addition & 7 deletions thirdparty/vars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -349,12 +349,6 @@ FAST_FLOAT_NAME="fast-float-3.5.1.tar.gz"
FAST_FLOAT_SOURCE="fast-float-3.5.1"
FAST_FLOAT_MD5SUM="adb3789b99f47e0cd971b4d90727d4d0"

# cachelib
CACHELIB_DOWNLOAD="https://cdn-thirdparty.starrocks.com/cachelib/cachelib-20230130.tar.gz"
CACHELIB_NAME="cachelib.tar.gz"
CACHELIB_SOURCE="cachelib"
CACHELIB_MD5SUM="7cc245be5cb10afa6aeea0121ec77e9e"

# streamvbyte
STREAMVBYTE_DOWNLOAD="https://github.com/lemire/streamvbyte/archive/refs/tags/v0.5.1.tar.gz"
STREAMVBYTE_NAME="streamvbyte-0.5.1.tar.gz"
Expand Down Expand Up @@ -419,5 +413,5 @@ CLUCENE_MD5SUM="d71f8156bbcbe78e5064ec5616072a5a"
TP_ARCHIVES="CLUCENE LIBEVENT OPENSSL THRIFT PROTOBUF GFLAGS GLOG GTEST RAPIDJSON SIMDJSON SNAPPY GPERFTOOLS ZLIB LZ4 BZIP CURL \
RE2 BOOST LEVELDB BRPC ROCKSDB KRB5 SASL LIBRDKAFKA PULSAR FLATBUFFERS ARROW BROTLI ZSTD S2 BITSHUFFLE CROARINGBITMAP \
JEMALLOC CCTZ FMT RYU BREAK_PAD HADOOP JDK RAGEL HYPERSCAN MARIADB JINDOSDK AWS_SDK_CPP VPACK OPENTELEMETRY \
BENCHMARK FAST_FLOAT CACHELIB STARCACHE STREAMVBYTE JANSSON AVRO SERDES GCS_CONNECTOR LZO2 DATASKETCHES \
BENCHMARK FAST_FLOAT STARCACHE STREAMVBYTE JANSSON AVRO SERDES GCS_CONNECTOR LZO2 DATASKETCHES \
ASYNC_PROFILER FIU LIBDEFLATE LLVM"

0 comments on commit 30e7e97

Please sign in to comment.