forked from apache/doris
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Feat](Nereids) support unset command (apache#43103)
### What problem does this PR solve? <!-- You need to clearly describe your PR in this part: migrate unset commands from original planner to nereids planner The description of the PR needs to enable reviewers to quickly and clearly understand the logic of the code modification. --> <!-- If there are related issues, please fill in the issue number. - If you want the issue to be closed after the PR is merged, please use "close apache#12345". Otherwise, use "ref apache#12345" --> Issue Number: close apache#43102 Problem Summary: ### Check List (For Committer) - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No colde files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> - Release note <!-- bugfix, feat, behavior changed need a release note --> <!-- Add one line release note for this PR. --> None ### Check List (For Reviewer who merge this PR) - [x] Confirm the release note - [x] Confirm test cases - [x] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
- Loading branch information
1 parent
800f5c6
commit ee635a8
Showing
9 changed files
with
523 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
...n/java/org/apache/doris/nereids/trees/plans/commands/UnsetDefaultStorageVaultCommand.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.nereids.trees.plans.commands; | ||
|
|
||
| import org.apache.doris.catalog.Env; | ||
| import org.apache.doris.cloud.catalog.CloudEnv; | ||
| import org.apache.doris.common.AnalysisException; | ||
| import org.apache.doris.common.Config; | ||
| import org.apache.doris.common.ErrorCode; | ||
| import org.apache.doris.common.ErrorReport; | ||
| import org.apache.doris.common.FeConstants; | ||
| import org.apache.doris.mysql.privilege.PrivPredicate; | ||
| import org.apache.doris.nereids.trees.plans.PlanType; | ||
| import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; | ||
| import org.apache.doris.qe.ConnectContext; | ||
| import org.apache.doris.qe.StmtExecutor; | ||
|
|
||
| /** | ||
| * Unset Default Storage Vault Command | ||
| */ | ||
| public class UnsetDefaultStorageVaultCommand extends Command implements ForwardWithSync { | ||
| public UnsetDefaultStorageVaultCommand() { | ||
| super(PlanType.UNSET_DEFAULT_STORAGE_VAULT_COMMAND); | ||
| } | ||
|
|
||
| public String toSql() { | ||
| final String stmt = "UNSET DEFAULT STORAGE VAULT"; | ||
| return stmt; | ||
| } | ||
|
|
||
| @Override | ||
| public void run(ConnectContext ctx, StmtExecutor executor) throws Exception { | ||
| if (Config.isNotCloudMode()) { | ||
| throw new AnalysisException("Storage Vault is only supported for cloud mode"); | ||
| } | ||
| if (!FeConstants.runningUnitTest) { | ||
| // In legacy cloud mode, some s3 back-ended storage does need to use storage vault. | ||
| if (!((CloudEnv) Env.getCurrentEnv()).getEnableStorageVault()) { | ||
| throw new AnalysisException("Your cloud instance doesn't support storage vault"); | ||
| } | ||
| } | ||
|
|
||
| // check auth | ||
| if (!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), PrivPredicate.ADMIN)) { | ||
| ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR, "ADMIN"); | ||
| } | ||
|
|
||
| ctx.getEnv().getStorageVaultMgr().unsetDefaultStorageVault(); | ||
| } | ||
|
|
||
| @Override | ||
| public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { | ||
| return visitor.visitUnsetDefaultStorageVaultCommand(this, context); | ||
| } | ||
| } |
160 changes: 160 additions & 0 deletions
160
...ore/src/main/java/org/apache/doris/nereids/trees/plans/commands/UnsetVariableCommand.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.nereids.trees.plans.commands; | ||
|
|
||
| import org.apache.doris.analysis.RedirectStatus; | ||
| import org.apache.doris.analysis.SetType; | ||
| import org.apache.doris.analysis.SetVar; | ||
| import org.apache.doris.analysis.StringLiteral; | ||
| import org.apache.doris.catalog.Env; | ||
| import org.apache.doris.common.AnalysisException; | ||
| import org.apache.doris.common.DdlException; | ||
| import org.apache.doris.common.ErrorCode; | ||
| import org.apache.doris.common.ErrorReport; | ||
| import org.apache.doris.common.UserException; | ||
| import org.apache.doris.mysql.privilege.PrivPredicate; | ||
| import org.apache.doris.nereids.trees.plans.PlanType; | ||
| import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; | ||
| import org.apache.doris.qe.ConnectContext; | ||
| import org.apache.doris.qe.StmtExecutor; | ||
| import org.apache.doris.qe.VariableMgr; | ||
|
|
||
| import org.apache.commons.lang3.StringUtils; | ||
| import org.apache.logging.log4j.LogManager; | ||
| import org.apache.logging.log4j.Logger; | ||
|
|
||
| /** | ||
| * UnSetVarOp | ||
| */ | ||
| public class UnsetVariableCommand extends Command implements Forward { | ||
| private static final Logger LOG = LogManager.getLogger(StmtExecutor.class); | ||
|
|
||
| private SetType setType; | ||
|
|
||
| // variable to restore | ||
| private String variable = null; | ||
|
|
||
| private boolean applyToAll = false; | ||
|
|
||
| public UnsetVariableCommand(SetType setType, String varName) { | ||
| super(PlanType.UNSET_VARIABLE_COMMAND); | ||
| this.setType = setType; | ||
| this.variable = varName; | ||
| } | ||
|
|
||
| public UnsetVariableCommand(SetType setType, boolean applyToAll) { | ||
| super(PlanType.UNSET_VARIABLE_COMMAND); | ||
| this.setType = setType; | ||
| this.applyToAll = applyToAll; | ||
| } | ||
|
|
||
| public SetType getSetType() { | ||
| return setType; | ||
| } | ||
|
|
||
| public String getVariable() { | ||
| return variable; | ||
| } | ||
|
|
||
| public boolean isApplyToAll() { | ||
| return applyToAll; | ||
| } | ||
|
|
||
| private void validate() throws UserException { | ||
| if (StringUtils.isEmpty(variable) && !applyToAll) { | ||
| throw new AnalysisException("You should specific the unset variable."); | ||
| } | ||
|
|
||
| if (setType == SetType.GLOBAL) { | ||
| if (!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), PrivPredicate.ADMIN)) { | ||
| ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR, | ||
| "ADMIN"); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * return sql expression of this command | ||
| * @return string of this command | ||
| */ | ||
| public String toSql() { | ||
| StringBuilder sb = new StringBuilder(); | ||
|
|
||
| sb.append("UNSET "); | ||
| sb.append(setType).append(" VARIABLE "); | ||
| if (!StringUtils.isEmpty(variable)) { | ||
| sb.append(variable).append(" "); | ||
| } else if (applyToAll) { | ||
| sb.append("ALL"); | ||
| } | ||
| return sb.toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public RedirectStatus toRedirectStatus() { | ||
| if (setType == SetType.GLOBAL) { | ||
| return RedirectStatus.FORWARD_WITH_SYNC; | ||
| } | ||
|
|
||
| return RedirectStatus.NO_FORWARD; | ||
| } | ||
|
|
||
| @Override | ||
| public void afterForwardToMaster(ConnectContext context) throws Exception { | ||
| if (isApplyToAll()) { | ||
| VariableMgr.setAllVarsToDefaultValue(context.getSessionVariable(), SetType.SESSION); | ||
| } else { | ||
| String defaultValue = VariableMgr.getDefaultValue(getVariable()); | ||
| if (defaultValue == null) { | ||
| ErrorReport.reportDdlException(ErrorCode.ERR_UNKNOWN_SYSTEM_VARIABLE, getVariable()); | ||
| } | ||
| SetVar var = new SetVar(SetType.SESSION, getVariable(), | ||
| new StringLiteral(defaultValue), SetVar.SetVarType.SET_SESSION_VAR); | ||
| VariableMgr.setVar(context.getSessionVariable(), var); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void run(ConnectContext ctx, StmtExecutor executor) throws Exception { | ||
| validate(); | ||
| try { | ||
| if (isApplyToAll()) { | ||
| VariableMgr.setAllVarsToDefaultValue(ctx.getSessionVariable(), getSetType()); | ||
| } else { | ||
| String defaultValue = VariableMgr.getDefaultValue(getVariable()); | ||
| if (defaultValue == null) { | ||
| ErrorReport.reportDdlException(ErrorCode.ERR_UNKNOWN_SYSTEM_VARIABLE, getVariable()); | ||
| } | ||
| SetVar var = new SetVar(getSetType(), getVariable(), | ||
| new StringLiteral(defaultValue), SetVar.SetVarType.SET_SESSION_VAR); | ||
| VariableMgr.setVar(ctx.getSessionVariable(), var); | ||
| } | ||
| } catch (DdlException e) { | ||
| LOG.warn("", e); | ||
| // Return error message to client. | ||
| ctx.getState().setError(ErrorCode.ERR_LOCAL_VARIABLE, e.getMessage() + toSql()); | ||
| return; | ||
| } | ||
| ctx.getState().setOk(); | ||
| } | ||
|
|
||
| @Override | ||
| public <R, C> R accept(PlanVisitor<R, C> visitor, C context) { | ||
| return visitor.visitUnsetVariableCommand(this, context); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.