add path-check, add XPRA_SYSCONF_DIR for xposix, add XDG_DATA_DIRS/icons to search path for pixmaps #3507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Xpra-org/xpra/blob/master/xpra/platform/xposix/menu_helper.py#L35
can return
None
and therefor needs to be checked for existance before use.it would help if the environment variable XPRA_SYSCONF_DIR can be used to overwrite the system default path.
Example:
We have multiple installations of Xpra on the same multi-user systems of a few hpc-clusters. The user/workflow can choose which of these installations is loaded using lmod, a framework to load software when needed into the current environment.
Xpra is therefore no real system-installations as they are installed to special directories each, and they are no user-installations as they are not installed by the user.
Hence it is needed to avoid that xpra looks at system paths (
/etc/xpra
) for configuration files.https://specifications.freedesktop.org/icon-theme-spec/latest/ar01s03.html