-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attach fails on Wayland with "NameError: name 'xsync' is not defined" #4377
Comments
That's odd because I do test under wayland, before every release. Something fishy is going on if you end up in this code path. xpra/xpra/platform/posix/keyboard.py Lines 28 to 32 in 9314110
This should guard against calling xsync: xpra/xpra/platform/posix/keyboard.py Lines 273 to 275 in 9314110
But I guess that the import is more strict: xpra/xpra/platform/posix/keyboard.py Lines 18 to 19 in 9314110
And it is possible to have both |
Wow, thanks for looking at this immediately. I believe this should entirely prevent the problem. I think what's actually going on here is I'm always getting XWayland under Xpra 6, and in spite of that I actually want it to always load under XWayland but I'm guessing this signals another issue, probably in the NixOS package. If I try to force native Wayland, GTK still tries to load in X11 mode.
(I did test that other Wayland apps are launching fine in the terminal.) I can't really dig into it right now but I will try to take a look soon. I don't want to waste your time on what is possibly a downstream problem. |
Describe the bug
Running
xpra attach
on Xpra 6.1.2 fails with the following error:Normally I would test with the latest HEAD just to be sure, but looking at the code I don't believe it's possible that the bug has been fixed since 6.1.2 was released.
Downstream report: NixOS/nixpkgs#347294
To Reproduce
It's easy to reproduce this bug even without Wayland because the way Wayland is detected is imperfect. e.g. You should be able to trigger it by setting
GDK_BACKEND="wayland" WAYLAND_DISPLAY=""
or something similar.System Information (please complete the following information):
Additional context
I normally use Xpra under XWayland, which makes more sense to me anyways given what it is doing. If I use
GDK_BACKEND=x11
then it works again, since the Wayland detection will then return false.The bug here seems to come down to the fact that although
xsync
is conditionally imported, it is still used unconditionally in some codepaths that are hit under Wayland. I'm not sure how this should be fixed. Maybe failing all else the commit that makes the import conditional should just be reverted for now.Thanks.
The text was updated successfully, but these errors were encountered: