Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse display urls using urllib.parse #3599

Closed
totaam opened this issue Aug 2, 2022 · 0 comments
Closed

parse display urls using urllib.parse #3599

totaam opened this issue Aug 2, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@totaam
Copy link
Collaborator

totaam commented Aug 2, 2022

urllib.parse

We can still support the old tcp:host:port syntax by pre-processing the string with a dumb search and replace.

Custom parsing code has already been removed in 82b0698
@totaam totaam added the enhancement New feature or request label Aug 2, 2022
@totaam totaam mentioned this issue Aug 2, 2022
Closed
totaam added a commit that referenced this issue Oct 19, 2022
@totaam
#3599 use urllib.parse rather than custom code
18720c1 
but still keep a bunch of mangling functions in normalize_display_name so we can support the older schemes a little while longer
totaam added a commit that referenced this issue Oct 20, 2022
@totaam
#3599 don't override main attributes with query string values
593bec1
totaam added a commit that referenced this issue Oct 20, 2022
@totaam
#3599 move more ssh parsing to a separate function
998b9c5
@totaam totaam closed this as completed Oct 20, 2022
totaam added a commit that referenced this issue Oct 20, 2022
@totaam
#3599 rename 'unix-domain' to 'socket'
1d188dc 
so that the client and server can become more symetrical:
the same noun can be used for client URLs (ie: 'socket:///some/path')
and the server object is now called a 'socket' type
@totaam totaam mentioned this issue Oct 21, 2022
Closed
totaam added a commit that referenced this issue Oct 24, 2022
@totaam
#3599 ugly parse_host_string() function was now unused
99274bb
This was referenced Nov 25, 2022
Closed
Closed
@totaam totaam mentioned this issue Jan 31, 2023
Closed
@totaam totaam mentioned this issue Mar 1, 2023
Closed
@adamhotep adamhotep mentioned this issue Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@totaam