Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent decompression DoS issues #3257

Closed
totaam opened this issue Sep 8, 2021 · 2 comments
Closed

prevent decompression DoS issues #3257

totaam opened this issue Sep 8, 2021 · 2 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Sep 8, 2021

Both the lz4 and zlib compressors now prevent decompressing packets that would consume too much memory: 83c72ba.
The default value is 256MB, which is enough for 8K in 32-bit BGRA format: 768043204 is ~128MB.

Unfortunately:

totaam added a commit that referenced this issue Sep 8, 2021
@totaam
Copy link
Collaborator Author

totaam commented Sep 8, 2021

Also removed lzo from:

@totaam
Copy link
Collaborator Author

totaam commented Sep 8, 2021

As for brotli, those concerned about memory bombs can disable it until we implement #3258.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant