-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xpra recover logs have no timestamps #3176
Comments
... or it was the recover 😅
|
The default value is:
Are you using In any case, we are talking about the contents of these log files, right?
I've used this particular line from the log file, but all of them look the same. What am I missing? |
Yes, so I can keep referencing old logs after the xpra upgrade 😛
Unfortunately nothing. Most of my interactions are exactly like that - except lengthier (of course). xpra start :20, and from another client (maybe even physically separate i.e. via ssh):
and then check the server logs? |
It was all my fault. Really sorry for being thick like that! Trivial fix in 8e1beee
You will be disconnected at this point. ... and we should auto-reconnect just like the HTML5 client already does, if I get around to it. |
Nooooooo, no no no, relax 😀 It's not like my reproduction steps are always crystal-clear 😂
You have so much on your plate, I wouldn't be looking so much forward to that.
Interesting code you have there. "It sounds to me" that you should have two lists (at least in testing): one with the above values, one with the other modes that you are explicitly not doing that. Then, in pytest: (I know I make it sound easy, and that "maybe" it's not as easy as that, but that might trigger to you a better idea to avoid introducing a regression like that again) |
I'll guess I'll have to verify this sometime next that I'll want to upgrade my server. |
Yes. I am closing as I am very confident this is fixed. Please re-open if not. |
Verified as fixed in r29406 (d03ead0) |
While checking why wasn't #3109 solved by your updates, I noticed that the
display-:2-$TIMESTAMP
logs afterxpra upgrade
are not prepended with timestamps.The text was updated successfully, but these errors were encountered: