Fix incorrect toolbar-position processing #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make floating toolbar keep the desired position on window resize. Signed-off-by: Vasyl Gello <vasek.gello@gmail.com>
|
This commit breaks the toolbar. |
|
Which browser is it? How to reproduce the issue? |
|
|
Ah, I forgot to limit it to "Floating menu" turned off. We should let it change position tracking window geometry if user wants the "fixed" menu and lets us determine its position.
Also, xpra-html5's preferences file should be moved on Unices from /usr/share/xpra to /etx/xpra and listed as conffile :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make floating toolbar keep the desired position
on window resize.