Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #280

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Update README.md #280

merged 1 commit into from
Jan 17, 2024

Conversation

manorit2001
Copy link
Contributor

Add uglifyjs dependency, not sure if this should come by default but on ubuntu jammy I needed to install this separately while installing this package with sudo.

Add uglifyjs dependency, this was required for me to install it.
@totaam
Copy link
Collaborator

totaam commented Jan 17, 2024

uglifyjs should not be strictly needed.
The build may spit out lots of warnings but it should proceed without doing any minification.

I am still merging this because it shouldn't cause any problems either. (most distros should have the package in their repos too nowadays)

@totaam totaam merged commit 98e1cac into Xpra-org:master Jan 17, 2024
1 check passed
@totaam
Copy link
Collaborator

totaam commented Jan 21, 2024

It only just occurred to me that this is on the front page and uses a Debian-only command (apt), so I am reverting this. Debian is the worst distribution to run xpra on.

There is already a commit which makes the minifier optional, so this is not needed at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants