Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for hjsmin minifier. #174

Merged
merged 2 commits into from
May 16, 2022
Merged

Add support for hjsmin minifier. #174

merged 2 commits into from
May 16, 2022

Conversation

arrowd
Copy link
Contributor

@arrowd arrowd commented May 15, 2022

No description provided.

@totaam totaam merged commit e181fd1 into Xpra-org:master May 16, 2022
@totaam
Copy link
Collaborator

totaam commented May 16, 2022

And... I should have reviewed this better:

Traceback (most recent call last):
  File "/opt/rpmbuild/BUILD/xpra-html5-5.0/./setup.py", line 588, in <module>
    sys.exit(main(sys.argv))
  File "/opt/rpmbuild/BUILD/xpra-html5-5.0/./setup.py", line 571, in main
    install_html5(root_dir, install_dir, config_dir, minifier=minifier)
  File "/opt/rpmbuild/BUILD/xpra-html5-5.0/./setup.py", line 306, in install_html5
    elif minifer=="hjsmin":
NameError: name 'minifer' is not defined
error: Bad exit status from /var/tmp/rpm-tmp.n6a5cn (%install)

totaam added a commit that referenced this pull request May 16, 2022
@totaam
#174 fixup typo in e181fd1
52a3d74
@arrowd
Copy link
Contributor Author

arrowd commented May 16, 2022

Oops, sorry for that.

totaam added a commit that referenced this pull request May 16, 2022
@totaam
#174 hjsmin compatibility
1903e42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arrowd @totaam