Update index.html #157
Merged
Update index.html #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Xpra-org#156 for me, at least with an updated simple-keyboard.min.js
totaam
reviewed
Feb 28, 2022
There was a problem hiding this comment.
Instead of hanging attributes directly from the window object, can't keyboardShifted be added to the keyboard object? Then you can just refer to kb and kb.keyboardShifted in the callbacks.
Edit: updated to the latest version of https://github.com/hodgef/simple-keyboard
totaam
added a commit
that referenced
this pull request
Feb 28, 2022
don't use the minified version in the repository, we minify when we install - this is a *source* repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #156 for me, at least with an updated simple-keyboard.min.js