Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview windows when alt-tabbing #140

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

JanCVanB
Copy link
Collaborator

@JanCVanB JanCVanB commented Jan 3, 2022

After pressing Alt+Tab but before releasing Alt, a semi-transparent popup visualizes the window stack and previews the next windows that each additional Tab press would select. Meanwhile, each real window change is instantly performed behind the popup.

Screen Shot 2022-01-03 at 1 37 26 PM
Screen Shot 2022-01-03 at 1 37 45 PM

Idea & implementation credit: @danisla

After pressing `Alt+Tab` but before releasing `Alt`, a semi-transparent popup visualizes the window stack and previews the next windows that each additional `Tab` press would select. Meanwhile, each real window change is instantly performed behind the popup.

Idea & implementation credit: @danisla
Copy link
Collaborator

@totaam totaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!

The only tiny complaint I have is about the javascript coding style.
And since my Javascript is terrible anyway, that's more of a wish than anything.

const preview_element = $('#window_preview');

preview_element.on('init', (e, slick) => {
if (init_cb) init_cb(e, slick);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For styling consistency, please use curly brackets and split this line.

@totaam totaam marked this pull request as ready for review January 4, 2022 13:55
@totaam totaam merged commit 224e148 into Xpra-org:master Jan 4, 2022
@totaam
Copy link
Collaborator

totaam commented Jan 4, 2022

This may be a silly question, but how do you prevent the OS from trapping Alt+Tab?

totaam added a commit that referenced this pull request Jan 4, 2022
@JanCVanB JanCVanB deleted the to_upstream/visual_alt_tab branch January 4, 2022 15:40
@JanCVanB
Copy link
Collaborator Author

JanCVanB commented Jan 4, 2022

@danisla, do you know the answer to @totaam's question?

JanCVanB pushed a commit to selkies-project/xpra-html5 that referenced this pull request Jan 4, 2022
…al_alt_tab

Preview windows when alt-tabbing
JanCVanB pushed a commit to selkies-project/xpra-html5 that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants