Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default-settings.txt missing on Ubuntu-20.04 #149

Closed
iDmple opened this issue Jan 20, 2022 · 8 comments
Closed

default-settings.txt missing on Ubuntu-20.04 #149

iDmple opened this issue Jan 20, 2022 · 8 comments
Labels
bug Something isn't working packaging

Comments

@iDmple
Copy link
Contributor

iDmple commented Jan 20, 2022 •
edited
Loading

Hi,

I noticed that the default-settings.txt file is missing on Ubuntu-20.04 official deb package because it creates a symlink to a location that does not have the file:

root@xpra-server-:/usr/share/xpra/www# ls -la default-settings.txt 
lrwxrwxrwx 1 root root 43 Dec 19 05:31 default-settings.txt -> /etc/xpra/html5-client/default-settings.txt

root@xpra-server:/usr/share/xpra/www# ls -la /etc/xpra/html5-client/default-settings.txt
ls: cannot access '/etc/xpra/html5-client/default-settings.txt': No such file or directory

Copy paste and such never worked for me, so I wonder if this is linked to this. I specified the options in xpra.conf, but I guess this wasn't the right place to do so.

Thanks
@iDmple iDmple changed the title default_settings.txt missing on Ubuntu-20.04 default-settings.txt missing on Ubuntu-20.04 Jan 20, 2022
@iDmple iDmple mentioned this issue Jan 20, 2022
Closed
@totaam
Copy link
Collaborator

totaam commented Jan 21, 2022

@basilgello ?

@totaam totaam added bug Something isn't working packaging labels Jan 21, 2022
@basilgello
Copy link
Contributor

@iDmple by official deb package you mean one in Xpra repo or in Ubuntu repo hosted by Canonical?

@totaam
Copy link
Collaborator

totaam commented Jan 21, 2022 •
edited
Loading

@basilgello I assume the xpra repo since he reported here and the change in packaging is way too recent to have made it in any Ubuntu repos.

@basilgello
Copy link
Contributor

@totaam OK let me run a test build for Ubuntu and check what is broken.

@iDmple
Copy link
Contributor Author

iDmple commented Jan 21, 2022 •
edited
Loading

Hey, sorry yes the Xpra repo! Xpra is version 4.5.2.

@totaam totaam mentioned this issue Feb 15, 2022
Merged
totaam added a commit that referenced this issue Feb 15, 2022
@totaam
#149 do all the copying and symlinking in one place
e2ac43c 
rather than duplicating the fragile logic in the spec file and setup.py

the script now takes an optional build root directory and installs properly in there, taking care of symlinks (creating them without the build root dir prefix)
@totaam
Copy link
Collaborator

totaam commented Feb 16, 2022

@iDmple please try the latest packages from the beta channel, those have the correct symlinks in place.

@totaam totaam closed this as completed Feb 16, 2022
@iDmple
Copy link
Contributor Author

iDmple commented Feb 16, 2022

Thanks for the fix! Will do.

@iDmple
Copy link
Contributor Author

iDmple commented Feb 21, 2022

I can confirm the bug is fixed on the beta channel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working packaging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@totaam @basilgello @iDmple