Skip to content

Use php version_compare to check XOOPS version #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mambax7 merged 1 commit into from
Jan 8, 2020
Merged

Use php version_compare to check XOOPS version #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 6 additions & 27 deletions class/utility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,34 +40,13 @@ class XoopsfaqUtility
*/
public static function checkVerXoops($module)
{
$moduleDirName = basename(dirname(__DIR__));
xoops_loadLanguage('admin', $module->dirname());
//check for minimum XOOPS version
$currentVer = substr(XOOPS_VERSION, 6); // get the numeric part of string
$currArray = explode('.', $currentVer);
$requiredVer = '' . $module->getInfo('min_xoops'); //making sure it's a string
$reqArray = explode('.', $requiredVer);
$success = true;
foreach ($reqArray as $k => $v) {
if (isset($currArray[$k])) {
if ($currArray[$k] > $v) {
break;
} elseif ($currArray[$k] == $v) {
continue;
} else {
$success = false;
break;
}
} else {
if ((int)$v > 0) { // handles versions like x.x.x.0_RC2
$success = false;
break;
}
}
}

$currentVersion = strtolower(str_replace('XOOPS ', '', XOOPS_VERSION));
$requiredVersion = strtolower($module->getInfo('min_xoops'));
$vc = version_compare ($currentVersion , $requiredVersion);
$success = ($vc>=0);
if (false === $success) {
$module->setErrors(sprintf(_AM_XOOPSFAQ_ERROR_BAD_XOOPS, $requiredVer, $currentVer));
xoops_loadLanguage('admin', $module->dirname());
$module->setErrors(sprintf(_AM_XOOPSFAQ_ERROR_BAD_XOOPS, $requiredVersion, $currentVersion));
}

return $success;
Expand Down