Skip to content

Commit

Permalink
Automated rollback of commit ac4741e.
Browse files Browse the repository at this point in the history
*** Reason for rollback ***

We have already fixed the synchronization issue below in  bazelbuild@9e87ad0. So it is okay to re-enable LabelInterner for all tests.

*** Original change description ***

Automated rollback of commit 4626c37.

*** Reason for rollback ***

We have discovered a synchronization issue in `InMemoryNodeEntry`. See http://shortn/_4NfZ22pQ1L.

*** Original change description ***

Enable `LabelInterner` for all tests

This is part of the plan to fully test the `LabelInterner` feature before global release.

PiperOrigin-RevId: 528884695
Change-Id: I0973a21c6cd06e51342e9f55caaa028cf6f5f65f
  • Loading branch information
yuyue730 authored and copybara-github committed May 2, 2023
1 parent e57d359 commit 92dc762
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
// limitations under the License.
package com.google.devtools.build.skyframe;

import com.google.devtools.build.lib.util.TestType;
import java.util.Objects;

/**
Expand All @@ -32,7 +33,8 @@
public final class UsePooledLabelInterningFlag {

private static final boolean USE_POOLED_LABEL_INTERNER =
Objects.equals(System.getProperty("BAZEL_USE_POOLED_LABEL_INTERNER"), "1");
Objects.equals(System.getProperty("BAZEL_USE_POOLED_LABEL_INTERNER"), "1")
|| TestType.isInTest();

public static boolean usePooledLabelInterningFlag() {
return USE_POOLED_LABEL_INTERNER;
Expand Down

0 comments on commit 92dc762

Please sign in to comment.