Skip to content

Commit

Permalink
Never allow local_resource_files in single-process tests
Browse files Browse the repository at this point in the history
RELNOTES: None
PiperOrigin-RevId: 177048616
  • Loading branch information
Googler authored and Copybara-Service committed Nov 27, 2017
1 parent f05b77e commit 82992e2
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
import com.android.utils.StdLogger;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Stopwatch;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableSet;
import com.google.devtools.build.android.AndroidDataMerger.MergeConflictException;
import com.google.devtools.build.android.AndroidResourceMerger.MergingException;
Expand Down Expand Up @@ -447,7 +446,6 @@ public static void main(String[] args) throws Exception {

if (hasConflictWithPackageUnderTest(
options.packageUnderTest,
options.primaryData.resourceDirs,
processedData.getManifest(),
timer)) {
logger.log(
Expand Down Expand Up @@ -532,19 +530,17 @@ public static void main(String[] args) throws Exception {
* <code>instrumentation</code> tags in this APK's manifest.
*
* @param packageUnderTest the package of the code under test, or null if no code is under test
* @param resourceDirs the resource directories for this APK
* @param processedManifest the processed manifest for this APK
*
* @return true if there is a conflict, false otherwise
*/
@VisibleForTesting
static boolean hasConflictWithPackageUnderTest(
@Nullable String packageUnderTest,
ImmutableList<Path> resourceDirs,
Path processedManifest,
Stopwatch timer)
throws SAXException, StreamException, ParserConfigurationException, IOException {
if (packageUnderTest == null || resourceDirs.isEmpty()) {
if (packageUnderTest == null) {
return false;
}

Expand Down

0 comments on commit 82992e2

Please sign in to comment.