Merge pull request phalcon#16598 from noone-silent/T16593-fix-memory-…

…leak-by-anonymous-function [phalcon#16593] - fix: fixed memory leak by anonymous function in PascalCase.zep
Xiphin · May 24, 2024 · 5c3d3fa · 5c3d3fa
2 parents 8d91b54 + 34be74c
commit 5c3d3fa
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/CHANGELOG-5.0.md b/CHANGELOG-5.0.md
@@ -11,6 +11,8 @@
 
 ### Fixed
 
+- Fixed `Phalcon\Support\Helper\PascalCase` causing memory leak by anonymous function [#16593](https://github.com/phalcon/cphalcon/issues/16593)
+
 ### Removed
 
 ## [5.7.0](https://github.com/phalcon/cphalcon/releases/tag/v5.7.0) (2024-05-17)

diff --git a/phalcon/Support/Helper/Str/PascalCase.zep b/phalcon/Support/Helper/Str/PascalCase.zep
@@ -25,18 +25,16 @@ class PascalCase
         string text,
         string delimiters = null
     ) -> string {
-        var exploded, output;
+        var exploded, output, element;
 
         let exploded = this->processArray(text, delimiters);
 
-        let output = array_map(
-            function (element) {
-                return ucfirst(mb_strtolower(element));
-            },
-            exploded
-        );
+        let output = "";
+        for element in exploded {
+            let output = output . ucfirst(mb_strtolower(element));
+        }
 
-        return implode("", output);
+        return output;
     }
 
     /**