Skip to content

Conversation

@gzliudan
Copy link
Collaborator

Proposed changes

start osaka fork

Ref: ethereum#31125

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copilot AI review requested due to automatic review settings January 29, 2026 03:23
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces Osaka fork awareness into the chain configuration and EVM selection logic, and wires the new fork into the global constants for all networks without activating it on mainnet/testnet/devnet yet.

Changes:

  • Extend ChainConfig and fork-handling helpers to support an OsakaBlock parameter, including description output, compatibility checks, and Rules.
  • Wire Osaka fork block into global constants for mainnet, testnet, devnet, and local networks, plus the shared constant struct and CopyConstants.
  • Update EVM instruction set lookup to recognize Prague as a fully defined fork (using the Prague jump table) and add a placeholder Osaka case that currently returns the Prague instruction set with an explicit "osaka-fork not defined yet" error.
  • Fix outdated comments referring to Ropsten by clarifying that the configs are for Apothem testnet and devnet.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
params/config.go Adds OsakaBlock to ChainConfig, initializes it for the various protocol-change configs, includes it in description output, compatibility checks, and Rules, and corrects testnet/devnet comments.
core/vm/jump_table_export.go Updates LookupInstructionSet to fully enable Prague’s instruction set and introduce an Osaka case that currently reuses the Prague instruction set while signaling that the Osaka fork is not yet defined.
common/constants.testnet.go Adds an osakaBlock field for Apothem testnet, initially set to math.MaxInt64 (disabled / far-future).
common/constants.mainnet.go Adds an osakaBlock field for mainnet, initially set to math.MaxInt64 (disabled / far-future).
common/constants.local.go Adds osakaBlock for local networks and moves Prague to block 0 so both Prague and Osaka are active from genesis for local testing.
common/constants.devnet.go Adds an osakaBlock field for devnet, initially set to math.MaxInt64 (disabled / far-future).
common/constants.all.go Extends the shared constant struct and the per-network global variables to include osakaBlock, and ensures CopyConstants correctly propagates the Osaka fork block.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants