Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip external consts when walking operands #96

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Skip external consts when walking operands #96

merged 1 commit into from
Oct 4, 2024

Conversation

jorickert
Copy link
Contributor

No description provided.

@jorickert jorickert requested a review from ttjost October 4, 2024 12:35
ttjost
ttjost requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@ttjost ttjost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • I wonder if we can't get the IFMs from getSubgraphIFMs as we do for ICC and PseudoOpConcats.
  • Once the first is answer, could you add LIT test?

@jorickert
Copy link
Contributor Author

Two things:

  • I wonder if we can't get the IFMs from getSubgraphIFMs as we do for ICC and PseudoOpConcats.
  • Once the first is answer, could you add LIT test?

I think only ICCs and PseudoOps have `IfmOperands.

I will add a lit test

@ttjost
Copy link
Contributor

ttjost commented Oct 4, 2024

Two things:

  • I wonder if we can't get the IFMs from getSubgraphIFMs as we do for ICC and PseudoOpConcats.
  • Once the first is answer, could you add LIT test?

I think only ICCs and PseudoOps have `IfmOperands.

I will add a lit test

I don't think we limit IfmOperands to ICC and PseudoOp. They should also be in TGs

@jorickert jorickert force-pushed the jrickert.filter_external_consts branch from a760d41 to f953f8e Compare October 4, 2024 13:38
@jorickert jorickert requested a review from ttjost October 4, 2024 13:39
@ttjost ttjost merged commit b58d735 into feature/fused-ops Oct 4, 2024
2 checks passed
@ttjost ttjost deleted the jrickert.filter_external_consts branch October 4, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttjost ttjost ttjost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorickert @ttjost