[WIP] Stateful Destructive Device Slicing #2726
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunhoffe
requested review from
AndraBisca,
andrej,
fifield,
jackl-xilinx,
jgmelber,
pvasireddy-amd and
stephenneuendorffer
as code owners
hunhoffe
changed the title
21 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements stateful destructive device slicing, allowing devices to be partitioned into non-overlapping views. Device classes are now stored as class references rather than instances in the configuration, and slicing operations claim tiles to prevent double allocation.
- Introduces
DeviceViewandDeviceLikeclasses to support device slicing with tile claiming - Modifies device configuration to store device classes instead of instances
- Updates
SequentialPlacerto remove thecores_per_colparameter and use device slicing instead
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/python/set_current_device.py | Tests device class-based configuration and multiple device type handling |
| test/python/placer_tests.py | Updates tests to use device slicing instead of cores_per_col parameter |
| test/python/device_slicing.py | Adds comprehensive test coverage for device slicing functionality |
| python/iron/program.py | Removes device instance recreation logic |
| python/iron/placers.py | Removes cores_per_col parameter and fixes device.cols reference |
| python/iron/hostruntime/config.py | Changes device storage from instances to classes |
| python/iron/device/device.py | Implements DeviceLike, DeviceView, and Device slicing with tile claiming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements stateful destructive device slicing, allowing devices to be partitioned into non-overlapping views. Device classes are now stored as class references rather than instances in the configuration, and slicing operations claim tiles to prevent double allocation.
DeviceViewandDeviceLikeclasses to support device slicing with tile claimingSequentialPlacerto remove thecores_per_colparameter and use device slicing insteadThis feature, together with a stateful
SequentialPlacer, is likely enough to use the placer across designs so that placed designs could be combined. That thought is for a future PR though.Thanks to copilot for the assist in the summary writing!